Jose Berrocal - Bootcamp solutions#111
Open
gran-jlberrocal wants to merge 9 commits intosimpleviewinc:masterfrom
Open
Jose Berrocal - Bootcamp solutions#111gran-jlberrocal wants to merge 9 commits intosimpleviewinc:masterfrom
gran-jlberrocal wants to merge 9 commits intosimpleviewinc:masterfrom
Conversation
tiffanyhardin
requested changes
Mar 19, 2025
Contributor
tiffanyhardin
left a comment
There was a problem hiding this comment.
Hi Jose,
This looks really good. Most of the assignments are correct.
I left some comments inline in the code for items you should address. This is how we usually review each others' work, so I wanted you to get used to this format.
I'll work on fixing the outdated placeholder image links throughout the bootcamp.
Thanks, Tiffany
fix issues found during code review process
Contributor
tiffanyhardin
left a comment
There was a problem hiding this comment.
Hi Jose,
Thanks for making those updates, you got almost everything.
- When going through the code review feedback, please don't mark conversations as resolved. The reviewer should do that after checking again.
- Week 1.1 - HTML/4. Mock Up a Design/index.html
My main point for this one was to use headers in order of h1, h2, h3 without skipping a level. Yours has h1, h3, and h4. You don't need to change it, but please remember that for the future. - Week 1.2 - CSS/6. Tricks - Click Passthrough/index.html
Changing the position from absolute to relative hides the overlay altogether, which incorrectly modifies the original design. Instead, add this: pointer-events: none;
Thanks, Tiffany
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.